[ADDED] Patch for bug and new feature
Moderator: Renato
Re: Patch for bug and new feature
I have found what is wrong. Your database has for US DOLLAR conversion to base rate = 31.653549 (Tools\Organize Currencies).
So, my changes are valid. But I think for all reports and " Income vs Expenses: Current Month" on home page we must calculate sums per each currency (or for database currency if we don't want to waste space on home page).
So, my changes are valid. But I think for all reports and " Income vs Expenses: Current Month" on home page we must calculate sums per each currency (or for database currency if we don't want to waste space on home page).
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
But it's nothing wrong!
I have Tools - Options - Others - Enable online currency update (Get data from European Central Bank)=Yes
Then "Tools - Online Update Currency Rate" has been done.
I have Tools - Options - Others - Enable online currency update (Get data from European Central Bank)=Yes
Then "Tools - Online Update Currency Rate" has been done.
Re: Patch for bug and new feature
Ok, I need more time to resolve this situation.
Re: Patch for bug and new feature
I have fixed this issue.
1.The program has default database currency. You can change one in Tools\Options\Generas Settings\Base currency.
2.Before my changes the program calculated "Total of Accounts:" as sum per every account
account.initialBalance + account.Balanse * account_currency."Conversion to base rate".
Thus, "Total of Accounts:" value always measured in default database currency.
In your case,
RUR -1p.
US_DOLLAR $ -1*31.65 (conversion to base rate of USD currency)
Expenses = 32.65p (1p + 31.65p)
Now I don't use conversion to base rate when calculates total sum per every currency.
3."Income vs Expenses: Current Month" values before my changes and now also use units of default currency.
When your default currency is RUR, these values will be XXX RUR.
When you switch default currency to USD, these values will be $XXX.
1.The program has default database currency. You can change one in Tools\Options\Generas Settings\Base currency.
2.Before my changes the program calculated "Total of Accounts:" as sum per every account
account.initialBalance + account.Balanse * account_currency."Conversion to base rate".
Thus, "Total of Accounts:" value always measured in default database currency.
In your case,
RUR -1p.
US_DOLLAR $ -1*31.65 (conversion to base rate of USD currency)
Expenses = 32.65p (1p + 31.65p)
Now I don't use conversion to base rate when calculates total sum per every currency.
3."Income vs Expenses: Current Month" values before my changes and now also use units of default currency.
When your default currency is RUR, these values will be XXX RUR.
When you switch default currency to USD, these values will be $XXX.
- Attachments
-
- trunk_diffs2.zip
- (5.56 KiB) Downloaded 528 times
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Hi,
It's more better.
(1 EUR= 45.45 EUR; 1 USD=31.65 RUB)
45.45+31.65+1=78.1
I have added one stock investment account. It has been created in USD but it has been recalculated to RUB.
And now lacks the Total in base currency (as was before).
Samples attached.
It's more better.
(1 EUR= 45.45 EUR; 1 USD=31.65 RUB)
45.45+31.65+1=78.1
I have added one stock investment account. It has been created in USD but it has been recalculated to RUB.
And now lacks the Total in base currency (as was before).
Samples attached.
- Attachments
-
- new6.zip
- (2.68 KiB) Downloaded 555 times
-
- 1112009-08-08_211946.png
- (9.87 KiB) Downloaded 2144 times
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Sample how it was before:
- Attachments
-
- homepagesample0.png
- (13.38 KiB) Downloaded 2142 times
Re: Patch for bug and new feature
Hi,
I reverted "Total". Now "Total" and "Total of Accounts" will be shown always.
Table "Currency - Summary" will be shown only when you have the same currency
in more than one account\asset\stock and balance for this account != 0.
I reverted "Total". Now "Total" and "Total of Accounts" will be shown always.
Table "Currency - Summary" will be shown only when you have the same currency
in more than one account\asset\stock and balance for this account != 0.
- Attachments
-
- trunk_diff.zip
- (6.85 KiB) Downloaded 692 times
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Hi,
Now this is an excellent and even better than I could wish for. Thank you very much.
A sample for the database in which the base currency is USD, and three accounts in RUB, EUR and USD.
Now this is an excellent and even better than I could wish for. Thank you very much.
A sample for the database in which the base currency is USD, and three accounts in RUB, EUR and USD.
- Attachments
-
- homepagesample2.png
- (12.27 KiB) Downloaded 2133 times
Re: Patch for bug and new feature
And thanks to you!
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Hi,
It seems that when there are no Assets the Table "Currency - Summary" does not appears.
It seems that when there are no Assets the Table "Currency - Summary" does not appears.
Re: Patch for bug and new feature
Hi,
table "Currency - Summary" will be shown only when you have the same currency
in more than one account\asset\stock and balance for this line != 0. You can attach database that I can check if am I right.
table "Currency - Summary" will be shown only when you have the same currency
in more than one account\asset\stock and balance for this line != 0. You can attach database that I can check if am I right.
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Hm....
Something wrong...
Check, please this DB:
Something wrong...
Check, please this DB:
- Attachments
-
- new8.zip
- (3.4 KiB) Downloaded 594 times
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Sorry.
Has been updated!
Has been updated!
Re: Patch for bug and new feature
There is no need to show "Currency-Summary" table for this case.
You have
BillNo1 $-1.00
EUR 0,00€
RUB 00р.
Stocks - zero
Assets - zero
The "Currency-Summary" will duplicate information that you already see on screen.
But when Stocks or Assets will have non zero balance (in RUR), the table will be shown
because you do not see full RUR's sum. Or when you add new account in RUR or EUR or USD
with non zero balance.
You have
BillNo1 $-1.00
EUR 0,00€
RUB 00р.
Stocks - zero
Assets - zero
The "Currency-Summary" will duplicate information that you already see on screen.
But when Stocks or Assets will have non zero balance (in RUR), the table will be shown
because you do not see full RUR's sum. Or when you add new account in RUR or EUR or USD
with non zero balance.
Last edited by Vadim on Fri Aug 14, 2009 1:33 pm, edited 1 time in total.
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Could You, please, explain why? There are 3 accounts with 3 different currency in the DB.
And why it shown when I added Asset?
And why it shown when I added Asset?
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Some thing wrong! There are 30 Roubles in the account RUB.
- Attachments
-
- 123.png
- (17.88 KiB) Downloaded 2078 times
Re: Patch for bug and new feature
не понял что не так, -30 руб на счету + 1руб в Assets = -29 всего
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Удаляем имущество и нет информации по валютам
Re: Patch for bug and new feature
А зачем тебе лишняя информация на экране? Мне не трудно всегда выводить таблицу, ести так надо.
Но в данном случае ты уже имеешь по всем валютам балансы. А когда одна валюта появляется в нескольких строках, суммы по ней уже не видно, тогда я вывожу таблицу по валютам.
Но в данном случае ты уже имеешь по всем валютам балансы. А когда одна валюта появляется в нескольких строках, суммы по ней уже не видно, тогда я вывожу таблицу по валютам.
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Дошло. Типа надо более двух счетов с одной валютой!
Спасибо!
All right!
Спасибо!
All right!
Re: Patch for bug and new feature
В нескольких строках - это например рубли в счёте "RUB" и рубли в Assets. Уже общей суммы не видно.
А удаляешь Asset - и баланс по "RUB" в рублях, и больше рублей нигде нету, поэтому и таблица особо не нужна.
А удаляешь Asset - и баланс по "RUB" в рублях, и больше рублей нигде нету, поэтому и таблица особо не нужна.
Re: Patch for bug and new feature
Ага, именно так!Nikolay wrote:Дошло. Типа надо более двух счетов с одной валютой!
-
- New User
- Posts: 1
- Joined: Sat Aug 15, 2009 8:58 pm
- Are you a spam bot?: No
- Location: Switzerland
Re: Patch for bug and new feature
Hi,
sorry for jumping in into your discussion. I have just become a new user of the program and must say, I'm very impressed. Congratulations!
Now, I struggle with a similar problem, and maybe it is the same. What I found out is the following:
If you have a bank account list, where the LAST account is in the default currency, everything shows up correctly.
But if the last Account is -say in Euros, but the default currency is in $, the the total amount will still be correct, but it shows Euros.
I have played around with the accounts. In the total, the Prefix is always according to the last listed account.
I hope,that helps a bit to solve the problem. I will check again later on.
Greetings from Switzerland
Beat
sorry for jumping in into your discussion. I have just become a new user of the program and must say, I'm very impressed. Congratulations!
Now, I struggle with a similar problem, and maybe it is the same. What I found out is the following:
If you have a bank account list, where the LAST account is in the default currency, everything shows up correctly.
But if the last Account is -say in Euros, but the default currency is in $, the the total amount will still be correct, but it shows Euros.
I have played around with the accounts. In the total, the Prefix is always according to the last listed account.
I hope,that helps a bit to solve the problem. I will check again later on.
Greetings from Switzerland
Beat
-
- Developer
- Posts: 1535
- Joined: Sat Dec 06, 2008 2:27 pm
- Are you a spam bot?: No
- Location: Sankt-Petersburg, Russia
Re: Patch for bug and new feature
Yes. Thanks. A similar problem I have described here:
http://www.codelathe.com/forum/viewtopic.php?f=5&t=552
http://www.codelathe.com/forum/viewtopic.php?f=5&t=552
Re: Patch for bug and new feature
I checked in trunk_diff.zip into SVN version 395.