[ADDED] Patch for feature "Notes Column Display"

Money Manager Ex Development related posts
(http://github.moneymanagerex.org/)

Moderator: Renato

Post Reply
elliswr
MMEX Developer
Posts: 102
Joined: Tue May 05, 2009 8:21 am
Are you a spam bot?: No
Location: Granbury, TX
Contact:

[ADDED] Patch for feature "Notes Column Display"

Post by elliswr »

I added another column to the checking panel display to show the notes. This feature is quite handy.

Edit: I finished adding the Notes column to the Repeating transactions page, so I am uploading a patch for both items as it is the same feature request.
Attachments
patch20090615.zip
updated patch for Notes column display
(1.63 KiB) Downloaded 383 times
Last edited by elliswr on Mon Jun 15, 2009 4:49 am, edited 1 time in total.

SandieE
New MMEX User
Posts: 1
Joined: Thu Feb 05, 2009 12:04 am

Re: Patch for adding requested feature "Notes Column Display"

Post by SandieE »

I downloaded the patch but I am not sure what I am supposed to do with it. It looks like C++ code. Where should this code be put? Also, the file generated has no extension on it either. When I unzip the file it is called patch20090612.

Thanks,
Sandie

elliswr
MMEX Developer
Posts: 102
Joined: Tue May 05, 2009 8:21 am
Are you a spam bot?: No
Location: Granbury, TX
Contact:

Re: Patch for adding requested feature "Notes Column Display"

Post by elliswr »

Do not adjust your monitor, it really is C++ code. The patch that I have submitted is actually the result of an svn diff. When I modify a copy of the source code that I obtained through sourceforge and I am happy with it, I do a difference on it to show all the changes that I have made. The patch shows all the code that I removed / replaced / added. You can see all of this by opening it in a text editor. This patch is not for the end user however. Once accepted, it is committed, and the new source code is available through svn. Then the package maintainers, who keep the binaries up do date, rebuild them with the new code, and post them for download to the average user. But of course anyone can build the binary.

madhan
Site Admin
Posts: 99
Joined: Sun Nov 30, 2008 8:06 pm

Re: Patch for adding requested feature "Notes Column Display"

Post by madhan »

Ellis, my email to you bounced, please continue to use the forum for posting patches. Thanks!

arb
New MMEX User
Posts: 3
Joined: Wed Jul 29, 2009 5:05 pm
Are you a spam bot?: No

Re: Patch for adding requested feature "Notes Column Display"

Post by arb »

Hi elliswr, thanks very much for that feature, I've just started using mmex and it's something I noticed straight away was missing!

madhan
Site Admin
Posts: 99
Joined: Sun Nov 30, 2008 8:06 pm

Re: Patch for adding requested feature "Notes Column Display"

Post by madhan »

Done. Thanks!

Nikolay
MMEX Developer
Posts: 1377
Joined: Sat Dec 06, 2008 2:27 pm
Are you a spam bot?: No
Location: Sankt-Petersburg, Russia

Re: [ADDED] Patch for feature "Notes Column Display"

Post by Nikolay »

Hi,

Link for this patch seems broken? Where I can download the patch?

elliswr
MMEX Developer
Posts: 102
Joined: Tue May 05, 2009 8:21 am
Are you a spam bot?: No
Location: Granbury, TX
Contact:

Re: [ADDED] Patch for feature "Notes Column Display"

Post by elliswr »

I don't have this patch anymorebut the code has been comitted and it works on the repeating transactions page. The column is not visible on the account transaction page in the new build and I dont know why, but I figure I'll just work on getting the new version out and then work on refining. So if you would, could you checkout the new build from svn and tell me if it works on windows or Linux?

Nikolay
MMEX Developer
Posts: 1377
Joined: Sat Dec 06, 2008 2:27 pm
Are you a spam bot?: No
Location: Sankt-Petersburg, Russia

Re: [ADDED] Patch for feature "Notes Column Display"

Post by Nikolay »

Hi,

Many thanks. I have done it already.

Vadim
MMEX Developer
Posts: 142
Joined: Mon Aug 03, 2009 7:35 am
Are you a spam bot?: No

Re: [ADDED] Patch for feature "Notes Column Display"

Post by Vadim »

Hi,
I have noticed that:
1.Text in "Notes" has right alignment (but comment should has left alighment).
2.The "Notes" width does not save between sessions. The reasion is lack of record for "Notes" in runtime\mmexini.db3 database. First we need to add this record
insert into setting_v1(settingid, settingname, settingvalue) values(30, 'CHECK_COL8_WIDTH', <some_default_width>);
And next check code which should update this value when user changed column's width.

Post Reply